This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE343760: [clangd] Support refs() in dex. Largely cloned
from MemIndex. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52726?vs=168242&id=168243#toc
Reposito
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
sammccall updated this revision to Diff 168242.
sammccall marked an inline comment as done.
sammccall added a comment.
Fix test and comment, and sync
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52726
Files:
clangd/index/Serialization.cpp
clangd/index/dex/Dex.cpp
clangd
sammccall marked 2 inline comments as done.
sammccall added inline comments.
Comment at: unittests/clangd/DexTests.cpp:618
+Files.push_back(R.Location.FileURI);
+ });
+}
hokein wrote:
> The test seems doesn't verify any thing?
Oops, thanks!
Repository:
r
hokein added inline comments.
Comment at: clangd/index/dex/Dex.h:61
}
// Symbols are owned by BackingData, Index takes ownership.
+ template
nit: this comment is stale too.
Comment at: unittests/clangd/DexTests.cpp:618
+Files.push_b
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric, ilya-biryukov.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52726
Files:
clangd/index/Serialization.cpp
clangd/index/de
