[PATCH] D52611: [clangd] Add more tracing to index queries. NFC

2018-09-27 Thread Eric Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL343247: [clangd] Add more tracing to index queries. NFC (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52611 Files: clang

[PATCH] D52611: [clangd] Add more tracing to index queries. NFC

2018-09-27 Thread Eric Liu via Phabricator via cfe-commits
ioeric updated this revision to Diff 167336. ioeric marked 2 inline comments as done. ioeric added a comment. - address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52611 Files: clangd/index/MemIndex.cpp clangd/index/Merge.cpp clangd/index/dex/Dex.cpp Index:

[PATCH] D52611: [clangd] Add more tracing to index queries. NFC

2018-09-27 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added inline comments. Comment at: clangd/index/dex/Dex.cpp:143 "There must be no :: in query."); + trace::Span Tracer("Dex fuzzyFind"); FuzzyMatcher Filter(Req.Query); sammccall wrote: > We should attach the query tree to the span here. >

[PATCH] D52611: [clangd] Add more tracing to index queries. NFC

2018-09-27 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/index/Merge.cpp:42 // 3) now yield all the dynamic symbols we haven't processed. + trace::Span Tracer("MergedIndex fuzzyFind");

[PATCH] D52611: [clangd] Add more tracing to index queries. NFC

2018-09-27 Thread Eric Liu via Phabricator via cfe-commits
ioeric created this revision. ioeric added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52611 Files: clangd/index/MemIndex.cpp clangd/index/Merge.cpp clangd