[PATCH] D52538: [MinGW] Allow using ASan

2018-10-01 Thread Martin Storsjö via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL343537: [MinGW] Allow using ASan (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52538?vs=167817&id=167823#toc Reposit

[PATCH] D52538: [MinGW] Allow using ASan

2018-10-01 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In https://reviews.llvm.org/D52538#1251620, @rnk wrote: > Regarding ubsan, it probably works, I haven't tested it though. Ok, thanks. I guess ubsan doesn't need quite as intricate integration with the platform as asan does anyway. https://reviews.llvm.org/D52538

[PATCH] D52538: [MinGW] Allow using ASan

2018-10-01 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D52538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52538: [MinGW] Allow using ASan

2018-10-01 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. Regarding ubsan, it probably works, I haven't tested it though. https://reviews.llvm.org/D52538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52538: [MinGW] Allow using ASan

2018-10-01 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo updated this revision to Diff 167817. mstorsjo added a comment. Clarified the comment about shared MSVCRT, moved handling of `.dll.a` into a separate condition afterwards. https://reviews.llvm.org/D52538 Files: lib/Driver/ToolChain.cpp lib/Driver/ToolChains/MinGW.cpp lib/Driver/

[PATCH] D52538: [MinGW] Allow using ASan

2018-10-01 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added inline comments. Comment at: lib/Driver/ToolChain.cpp:370-373 + const char *Suffix = Shared ? (Triple.isWindowsGNUEnvironment() + ? ".dll.a" + : Triple.isOSWindows() ? ".lib" : ".so")

[PATCH] D52538: [MinGW] Allow using ASan

2018-10-01 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: lib/Driver/ToolChain.cpp:370-373 + const char *Suffix = Shared ? (Triple.isWindowsGNUEnvironment() + ? ".dll.a" + : Triple.isOSWindows() ? ".lib" : ".so")

[PATCH] D52538: [MinGW] Allow using ASan

2018-10-01 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. Ping Repository: rC Clang https://reviews.llvm.org/D52538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52538: [MinGW] Allow using ASan

2018-09-28 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. Ping @rnk in case you have time to look at it despite CppCon Repository: rC Clang https://reviews.llvm.org/D52538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D52538: [MinGW] Allow using ASan

2018-09-26 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. Also, I notice that ubsan also is built for windows, but in the MSVC toolchain, only asan (and libfuzzer) can be enabled, not ubsan. Is there something else missing for ubsan, or what's the matter with that one? Repository: rC Clang https://reviews.llvm.org/D52538

[PATCH] D52538: [MinGW] Allow using ASan

2018-09-26 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo created this revision. mstorsjo added a reviewer: rnk. Linking to ASan for MinGW is similar to MSVC, but MinGW always links the CRT dynamically, so there is only one of the MSVC cases to consider. When linking to a shared compiler runtime library on MinGW, the suffix of the import libr