This revision was automatically updated to reflect the committed changes.
Closed by commit rC344665: AMDGPU: add __builtin_amdgcn_update_dpp (authored by
yaxunl, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52320?vs=169882&id=169942#toc
Repository:
rC Clang
https://rev
yaxunl added a comment.
Brian checked the extra argument for dpp mov should be the first one. so
mov_dpp(x,...) --> update_dpp(undef, x, ...). I will fix that when committing.
https://reviews.llvm.org/D52320
___
cfe-commits mailing list
cfe-commits
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D52320
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
yaxunl updated this revision to Diff 169882.
yaxunl edited the summary of this revision.
yaxunl added a comment.
emit llvm.amdgcn.update.dpp for __builtin_amdgcn_mov_dpp.
https://reviews.llvm.org/D52320
Files:
include/clang/Basic/BuiltinsAMDGPU.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGenOp
b-sumner added a comment.
Ping. There's quite a bit of interest in getting this exposed by clang.
https://reviews.llvm.org/D52320
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:11313-11315
+ case AMDGPU::BI__builtin_amdgcn_update_dpp: {
+llvm::SmallVector Args;
+for (unsigned I = 0; I != 6; ++I)
b-sumner wrote:
> arsenm wrote:
> > The only difference between th
b-sumner added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:11313-11315
+ case AMDGPU::BI__builtin_amdgcn_update_dpp: {
+llvm::SmallVector Args;
+for (unsigned I = 0; I != 6; ++I)
arsenm wrote:
> The only difference between this and mov_dpp is
arsenm added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:11313-11315
+ case AMDGPU::BI__builtin_amdgcn_update_dpp: {
+llvm::SmallVector Args;
+for (unsigned I = 0; I != 6; ++I)
The only difference between this and mov_dpp is the argument count
yaxunl created this revision.
yaxunl added reviewers: kzhuravl, b-sumner, arsenm.
Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely.
https://reviews.llvm.org/D52320
Files:
include/clang/Basic/BuiltinsAMDGPU.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGenOpenCL/builtins-amd
