glaubitz added a comment.
Not sure how this is supposed to be tested as this requires a proper Debian
powerpcspe chroot.
I also checked saw that not all mips64 include paths are covered by the
testsuite.
Repository:
rL LLVM
https://reviews.llvm.org/D52066
___
lebedev.ri added inline comments.
Comment at: cfe/trunk/lib/Driver/ToolChains/Linux.cpp:701
"/usr/include/mips64el-linux-gnuabi64"};
const StringRef PPCMultiarchIncludeDirs[] = {
+ "/usr/include/powerpc-linux-gnu",
This is probably missing test cov
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342231: [Driver] Fix missing MultiArch include dir on
powerpcspe (authored by kristina, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D52066
Files:
lib/Driver/ToolChains/Linux.cpp
I
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342231: [Driver] Fix missing MultiArch include dir on
powerpcspe (authored by kristina, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52066?
kristina accepted this revision.
kristina added a comment.
This revision is now accepted and ready to land.
LGTM.
In the future please make sure you supply all patches with context (ie.
`-U9`), without context they may be harder to review and more importantly
`patch` may mess up.
Reposito
glaubitz added a comment.
I don't have commit access, btw. So it would be nice if someone else could
commit this for me.
Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D52066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
glaubitz created this revision.
glaubitz added reviewers: kristina, dschuff.
Herald added subscribers: cfe-commits, nemanjai.
On powerpc-linux-gnuspe, the header files are located in their
own include directory named /usr/lib/powerpc-linux-gnuspe,
so add this directory to PPCMultiarchIncludeDirs.
