[PATCH] D51997: [clang] Make sure attributes on member classes are applied properly

This revision was automatically updated to reflect the committed changes. Closed by commit rC342238: [clang] Make sure attributes on member classes are applied properly (authored by ldionne, committed by ). Changed prior to commit: https://reviews.llvm.org/D51997?vs=165375&id=165502#toc Reposi

[PATCH] D51997: [clang] Make sure attributes on member classes are applied properly

erik.pilkington added a comment. Looks good to me! @rsmith should probably have the final word though. Thanks for fixing this. Repository: rC Clang https://reviews.llvm.org/D51997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D51997: [clang] Make sure attributes on member classes are applied properly

ldionne added a comment. I created https://bugs.llvm.org/show_bug.cgi?id=38942 to keep track of the problem for partial specializations and explicit specializations. Moving forward with this patch will allow me to land the `no_extern_template` attribute. Repository: rC Clang https://review

[PATCH] D51997: [clang] Make sure attributes on member classes are applied properly

ldionne updated this revision to Diff 165375. ldionne added a comment. Drop support for partial specializations and explicit specializations. Address comments by Erik. Repository: rC Clang https://reviews.llvm.org/D51997 Files: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp clang/test/Se

[PATCH] D51997: [clang] Make sure attributes on member classes are applied properly

ldionne added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1268 + // Instantiate the attributes on both the template declaration and the associated record declaration. + SemaRef.InstantiateAttrsForDecl(TemplateArgs, Pattern, Inst, LateAttrs, Sta

[PATCH] D51997: [clang] Make sure attributes on member classes are applied properly

rsmith added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1268 + // Instantiate the attributes on both the template declaration and the associated record declaration. + SemaRef.InstantiateAttrsForDecl(TemplateArgs, Pattern, Inst, LateAttrs, Star

[PATCH] D51997: [clang] Make sure attributes on member classes are applied properly

ldionne marked 2 inline comments as done. ldionne added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1268 + // Instantiate the attributes on both the template declaration and the associated record declaration. + SemaRef.InstantiateAttrsForDecl(Te

[PATCH] D51997: [clang] Make sure attributes on member classes are applied properly

erik.pilkington added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1267-1269 + // Instantiate the attributes on both the template declaration and the associated record declaration. + SemaRef.InstantiateAttrsForDecl(TemplateArgs, Pattern, Inst, La

[PATCH] D51997: [clang] Make sure attributes on member classes are applied properly

ldionne added a comment. This patch is missing support for partial specializations and explicit specializations. The part I don't understand is how to get the `CXXRecordDecl`s to have the right attribute below. Here's the AST dump for the test file with the current patch: TranslationUnitDecl

[PATCH] D51997: [clang] Make sure attributes on member classes are applied properly

ldionne created this revision. ldionne added a reviewer: rsmith. Herald added subscribers: cfe-commits, dexonsmith. Attributes on member classes of class templates (and other similar entities) are not currently instantiated. This was discovered by Richard Smith here: http://lists.llvm.org/piper