[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

ilya-biryukov added a comment. Thanks for the comments everyone! Will land this tomorrow, since I'm buildcop this week anyway. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51987 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

ioeric accepted this revision. ioeric added a comment. In https://reviews.llvm.org/D51987#1232021, @sammccall wrote: > In https://reviews.llvm.org/D51987#1231993, @ioeric wrote: > > > In https://reviews.llvm.org/D51987#1231990, @ilya-biryukov wrote: > > > > > > You beat it to me, but I thought we

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

sammccall added a comment. In https://reviews.llvm.org/D51987#1231993, @ioeric wrote: > In https://reviews.llvm.org/D51987#1231990, @ilya-biryukov wrote: > > > > You beat it to me, but I thought we didn't use indexer as it could be > > > confused with the actual indexing? > > > > Sorry. Not a bi

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

ioeric added a comment. In https://reviews.llvm.org/D51987#1231990, @ilya-biryukov wrote: > > You beat it to me, but I thought we didn't use indexer as it could be > > confused with the actual indexing? > > Sorry. Not a big deal, can revert back if needed. > Mostly like indexer since it's short

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

kbobyrev added a comment. My 2 cents: `clangd-indexer` looks great! Typing 3-token tool name is always sad for me :( It's also easier to remember/understand in the first place. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51987 _

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

ilya-biryukov added a comment. > You beat it to me, but I thought we didn't use indexer as it could be > confused with the actual indexing? Sorry. Not a big deal, can revert back if needed. Mostly like indexer since it's shorter. Also not very confusing, since we call the thing it produces an "

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

ioeric added a comment. In https://reviews.llvm.org/D51987#1231971, @ilya-biryukov wrote: > `clangd-indexer` looks nice and short. @ioeric, WDYT? You beat it to me, but I thought we didn't use `indexer` as it could be confused with the actual `indexing`? Repository: rCTE Clang Tools Extra

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

ilya-biryukov updated this revision to Diff 165092. ilya-biryukov added a comment. - Rename to clangd-indexer Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51987 Files: clangd/CMakeLists.txt clangd/global-symbol-builder/CMakeLists.txt clangd/global-symbol-builder/GlobalS

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

ilya-biryukov added a comment. `clangd-indexer` looks nice and short. @ioeric, WDYT? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51987 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

sammccall accepted this revision. sammccall added a comment. Much better. I think `clangd-indexer` might be **even** better, but up to you. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51987 ___ cfe-commits mailing list cfe-commit

Re: [PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

I mean `clangd-symbol-builder` On Wed, Sep 12, 2018 at 4:32 PM Eric Liu via Phabricator < revi...@reviews.llvm.org> wrote: > ioeric accepted this revision. > ioeric added a comment. > This revision is now accepted and ready to land. > > lgtm > > +1 to `clang-symbol-builder` > > > Repository: >

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

ioeric added a subscriber: ilya-biryukov. ioeric added a comment. I mean `clangd-symbol-builder` Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51987 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm +1 to `clang-symbol-builder` Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51987 ___ cfe-commits mailing list cfe-commits

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

ilya-biryukov added a comment. We've used the new name internally before and now that we're testing this, we need to be consistent. The 'clangd-symbol-builder' looks like a better choice, so I'm pitching changing upstream first. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D5

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

ilya-biryukov updated this revision to Diff 165085. ilya-biryukov added a comment. - Rebase, updated the added test Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51987 Files: clangd/CMakeLists.txt clangd/global-symbol-builder/CMakeLists.txt clangd/global-symbol-builder/G

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

ilya-biryukov created this revision. ilya-biryukov added reviewers: ioeric, sammccall, kadircet. Herald added subscribers: arphaman, jkorous, MaskRay, mgorny. Given that the indexer binary is put directly into ./bin directory when built, 'clangd-' prefix seems to provide better context to the read