Re: [PATCH] D51852: [clangd] Implement FuzzyFindRequest JSON (de)serialization

2018-09-10 Thread Yvan Roux via cfe-commits
On Mon, 10 Sep 2018 at 16:36, Kirill Bobyrev via Phabricator wrote: > > kbobyrev added a comment. > > In https://reviews.llvm.org/D51852#1228883, @yroux wrote: > > > Hi Kirill, > > > > This commit broke ARMV8 buildbots, logs are available here: > > > > http://lab.llvm.org:8011/builders/clang-cma

[PATCH] D51852: [clangd] Implement FuzzyFindRequest JSON (de)serialization

2018-09-10 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added a comment. In https://reviews.llvm.org/D51852#1228883, @yroux wrote: > Hi Kirill, > > This commit broke ARMV8 buildbots, logs are available here: > > http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/6493/steps/build%20stage%201/logs/stdio > > Thanks > Yvan Hi! A

Re: [PATCH] D51852: [clangd] Implement FuzzyFindRequest JSON (de)serialization

2018-09-10 Thread Yvan Roux via cfe-commits
Hi Kirill, This commit broke ARMV8 buildbots, logs are available here: http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/6493/steps/build%20stage%201/logs/stdio Thanks Yvan On Mon, 10 Sep 2018 at 13:52, Kirill Bobyrev via Phabricator via llvm-commits wrote: > > This revision was a

[PATCH] D51852: [clangd] Implement FuzzyFindRequest JSON (de)serialization

2018-09-10 Thread Kirill Bobyrev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL341802: [clangd] Implement FuzzyFindRequest JSON (de)serialization (authored by omtcyfz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51852

[PATCH] D51852: [clangd] Implement FuzzyFindRequest JSON (de)serialization

2018-09-10 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 164648. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Revert unrelated formatting changes, simplify the comment. https://reviews.llvm.org/D51852 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clangd/index/Inde

[PATCH] D51852: [clangd] Implement FuzzyFindRequest JSON (de)serialization

2018-09-10 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1384 Req.ProximityPaths.push_back(FileName); -vlog("Code complete: fuzzyFind(\"{0}\", scopes=[{1}])",

[PATCH] D51852: [clangd] Implement FuzzyFindRequest JSON (de)serialization

2018-09-10 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev created this revision. kbobyrev added reviewers: ilya-biryukov, ioeric, sammccall. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. JSON (de)serialization of `FuzzyFindRequest` might be useful for both https://reviews.llvm.org/D