[PATCH] D51822: Support generating unique identifiers for Stmt objects

2018-09-14 Thread George Karpenkov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC342309: Support generating unique identifiers for Stmt objects (authored by george.karpenkov, committed by ). Changed prior to commit: https://reviews.llvm.org/D51822?vs=164547&id=165625#toc Repository

[PATCH] D51822: Support generating unique identifiers for Stmt objects

2018-09-13 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks as expected. I hope that assertion does actually hold. Should AST folks have a look as well? Comment at: clang/lib/AST/Stmt.cpp:310 + return *Out / alignof(Stmt); + +}

[PATCH] D51822: Support generating unique identifiers for Stmt objects

2018-09-07 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov created this revision. george.karpenkov added reviewers: NoQ, rsmith, bogner, aprantl, arphaman. Unlike pointer values, those identifiers are reproducible between the runs. https://reviews.llvm.org/D51822 Files: clang/include/clang/AST/Stmt.h clang/lib/AST/Stmt.cpp Index: