[PATCH] D51806: [clang-cl] Enable -march

This revision was automatically updated to reflect the committed changes. Closed by commit rC341847: [clang-cl] Enable -march option (authored by aganea, committed by ). Repository: rC Clang https://reviews.llvm.org/D51806 Files: include/clang/Driver/Options.td test/Driver/cl-options.c

RE: [PATCH] D51806: [clang-cl] Enable -march

Selvaraj via Phabricator Cc : Alexandre Ganea ; cfe-commits Objet : Re: [PATCH] D51806: [clang-cl] Enable -march On Mon, Sep 10, 2018 at 10:33 AM Hans Wennborg via Phabricator via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: hans added a comment. In https://reviews.llvm.org/

Re: [PATCH] D51806: [clang-cl] Enable -march

On Mon, Sep 10, 2018 at 10:33 AM Hans Wennborg via Phabricator via cfe-commits wrote: > hans added a comment. > > In https://reviews.llvm.org/D51806#1228893, @aganea wrote: > > > @hans Just an after thought: maybe we should prevent usage of `-march=` > and `/arch:` at the same time. What do you t

[PATCH] D51806: [clang-cl] Enable -march

hans added a comment. In https://reviews.llvm.org/D51806#1228893, @aganea wrote: > @hans Just an after thought: maybe we should prevent usage of `-march=` and > `/arch:` at the same time. What do you think? I can add another patch for > that purpose. Hmm, yes, at least we should warn or do so

[PATCH] D51806: [clang-cl] Enable -march

aganea added a comment. @hans Just an after thought: maybe we should prevent usage of `-march=` and `/arch:` at the same time. What do you think? I can add another patch for that purpose. Repository: rC Clang https://reviews.llvm.org/D51806 ___

[PATCH] D51806: [clang-cl] Enable -march

aganea added a comment. Thank you! Repository: rC Clang https://reviews.llvm.org/D51806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51806: [clang-cl] Enable -march

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D51806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D51806: [clang-cl] Enable -march

aganea updated this revision to Diff 164666. aganea added a comment. Updated diff with coverage test as requested. Repository: rC Clang https://reviews.llvm.org/D51806 Files: include/clang/Driver/Options.td test/Driver/cl-options.c Index: test/Driver/cl-options.c ==

[PATCH] D51806: [clang-cl] Enable -march

hans added a comment. Okay, that sounds good to me. Please also add a test for this in test/Driver/cl-options.c in the "Accept "core" clang options" section. Repository: rC Clang https://reviews.llvm.org/D51806 ___ cfe-commits mailing list cfe-

[PATCH] D51806: [clang-cl] Enable -march

aganea added a comment. @hans I want to target precisely a given CPU when using `clang-cl`. The options in the `m_x86_Features_Group` are too granular. It is easier to just add `-march=skylake` on the cmd-line. Is there any other way? Repository: rC Clang https://reviews.llvm.org/D51806

[PATCH] D51806: [clang-cl] Enable -march

hans added a comment. All flags in the m_x86_Features_Group, i.e. -msse, -mavx and so on are all supported. I'm just curious to hear what it is that you need from -march? Repository: rC Clang https://reviews.llvm.org/D51806 ___ cfe-commits maili

[PATCH] D51806: [clang-cl] Enable -march

aganea created this revision. aganea added reviewers: thakis, ddunbar, hans. Herald added a subscriber: cfe-commits. Currently, `-march` does not work in the `clang-cl` driver. We are currently migrating from MSVC. The project size makes that we have to stick with `clang-cl` for a little while.