[PATCH] D51789: [WIP][clang] Add the no_extern_template attribute

2018-09-14 Thread Louis Dionne via Phabricator via cfe-commits
ldionne updated this revision to Diff 165507. ldionne added a comment. Fix the tests and remove some warnings that I wasn't able to generate properly (to avoid false positives). Repository: rC Clang https://reviews.llvm.org/D51789 Files: clang/include/clang/Basic/Attr.td clang/include/cl

[PATCH] D51789: [WIP][clang] Add the no_extern_template attribute

2018-09-07 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. It'd be good to test that `[[no_extern_template]]` affects instantiation, not just code generation (eg, put something in the body of the entity that will trigger an error if instantiated, and check that the diagnostic is produced at the right times). Repository: rL L

[PATCH] D51789: [WIP][clang] Add the no_extern_template attribute

2018-09-07 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith edited subscribers, added: cfe-commits; removed: llvm-commits. dexonsmith added a comment. +cfe-commits -llvm-commits Repository: rL LLVM https://reviews.llvm.org/D51789 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li