This revision was automatically updated to reflect the committed changes.
Closed by commit rL341388: [CMake] Remove variable reference that isn't
used. (authored by cdavis, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D51644
Files:
li
mstorsjo accepted this revision.
mstorsjo added inline comments.
This revision is now accepted and ready to land.
Comment at: src/CMakeLists.txt:54
# Generate library list.
-set(libraries ${LIBUNWINDCXX_ABI_LIBRARIES})
+set(libraries)
append_if(libraries LIBUNWIND_HAS_C_LIB c)
cdavis5x added inline comments.
Comment at: src/CMakeLists.txt:54
# Generate library list.
-set(libraries ${LIBUNWINDCXX_ABI_LIBRARIES})
+set(libraries)
append_if(libraries LIBUNWIND_HAS_C_LIB c)
mstorsjo wrote:
> Is there any point in this line at all now, or
mstorsjo added inline comments.
Comment at: src/CMakeLists.txt:54
# Generate library list.
-set(libraries ${LIBUNWINDCXX_ABI_LIBRARIES})
+set(libraries)
append_if(libraries LIBUNWIND_HAS_C_LIB c)
Is there any point in this line at all now, or can it be removed
cdavis5x created this revision.
cdavis5x added reviewers: mstorsjo, rnk.
Herald added subscribers: cfe-commits, christof, mgorny.
This variable is never defined, so its value is always empty. Since
`libunwind` is needed to build the C++ ABI library in the first place,
it should never be linked to
