[PATCH] D51567: CMake: Consolidate gtest detection code

2019-11-14 Thread Tom Stellard via Phabricator via cfe-commits
tstellar abandoned this revision. tstellar added a comment. Herald added a project: clang. Dropping this since it is more Fedora specific. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51567/new/ https://reviews.llvm.org/D51567

[PATCH] D51567: CMake: Consolidate gtest detection code

2018-09-04 Thread Tom Stellard via Phabricator via cfe-commits
tstellar added a comment. In https://reviews.llvm.org/D51567#1222704, @chandlerc wrote: > I mean, sure. > > I really don't know that supporting this ever expanding diversity of build > strategies is worth its cost, but I don't see a specific reason to not take > this patch I actually agre

[PATCH] D51567: CMake: Consolidate gtest detection code

2018-09-04 Thread Chandler Carruth via Phabricator via cfe-commits
chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. I mean, sure. I really don't know that supporting this ever expanding diversity of build strategies is worth its cost, but I don't see a specific reason to not take this patch Rep

[PATCH] D51567: CMake: Consolidate gtest detection code

2018-08-31 Thread Tom Stellard via Phabricator via cfe-commits
tstellar created this revision. tstellar added reviewers: chandlerc, beanz. Herald added a subscriber: mgorny. This makes it possible to build the unittests with only the gtest sources and without a full LLVM source tree. Repository: rC Clang https://reviews.llvm.org/D51567 Files: CMakeLis