[PATCH] D51528: [NFC] Cleanup Dex

This revision was automatically updated to reflect the committed changes. Closed by commit rL341190: [NFC] Cleanup Dex (authored by omtcyfz, committed by ). Herald added subscribers: llvm-commits, ilya-biryukov. Changed prior to commit: https://reviews.llvm.org/D51528?vs=163485&id=163489#toc R

[PATCH] D51528: [NFC] Cleanup Dex

kbobyrev updated this revision to Diff 163485. kbobyrev marked 2 inline comments as done. https://reviews.llvm.org/D51528 Files: clang-tools-extra/clangd/index/dex/DexIndex.cpp clang-tools-extra/clangd/index/dex/DexIndex.h clang-tools-extra/clangd/index/dex/Iterator.cpp clang-tools-extra/

[PATCH] D51528: [NFC] Cleanup Dex

ioeric accepted this revision. ioeric added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/dex/DexIndex.cpp:33 std::vector Result = generateIdentifierTrigrams(Sym.Name); - Result.push_back(Token(Token::Kind::Scope,

[PATCH] D51528: [NFC] Cleanup Dex

kbobyrev added a comment. The next step would be to move Dex to index/ and slightly simplify file structure, but I guess I should consider doing that after https://reviews.llvm.org/D51422 lands, otherwise it's a lot of effort to keep rebasing everything on top of different patches. https://re

[PATCH] D51528: [NFC] Cleanup Dex

kbobyrev created this revision. kbobyrev added reviewers: ioeric, sammccall. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous. - Use consistent assertion messages in iterators implementations - Silence a bunch of clang-tidy warnings: use `emplace_b