This revision was automatically updated to reflect the committed changes.
Closed by commit rL341061: [clang-tidy] Use simple string matching instead of
Regex (authored by omtcyfz, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51360?v
kbobyrev updated this revision to Diff 163309.
kbobyrev marked an inline comment as done.
kbobyrev added a comment.
Mention that the code actually performs `absl/(any|absl|library)` substring
match.
https://reviews.llvm.org/D51360
Files:
clang-tools-extra/clang-tidy/abseil/AbseilMatcher.h
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D51360#1219024, @kbobyrev wrote:
> Ah, correct. I totally forgot about the `^string$` for the exact match.
>
> This should not change behavior now. I believe what yo
kbobyrev updated this revision to Diff 163302.
kbobyrev marked an inline comment as done.
kbobyrev added a comment.
Ah, correct. I totally forgot about the `^string$` for the exact match.
This should not change behavior now. I believe what you propose would make the
code easier (there'd only be
hokein added a comment.
Thanks very much for improving it!
Comment at: clang-tools-extra/clang-tidy/abseil/AbseilMatcher.h:45
- llvm::Regex RE(
- "absl/(algorithm|base|container|debugging|memory|meta|numeric|strings|"
- "synchronization|time|types|utility)");
---
kbobyrev created this revision.
kbobyrev added a reviewer: hokein.
kbobyrev added a project: clang-tools-extra.
Herald added a subscriber: xazax.hun.
Instead of parsing and compiling the `llvm::Regex` each time, it's faster to
use basic string matching for filename prefix check.
https://reviews
