[PATCH] D51292: [docs] Update clang-rename documentation

kbobyrev added a comment. @ioeric does it look better now? https://reviews.llvm.org/D51292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51292: [docs] Update clang-rename documentation

kbobyrev updated this revision to Diff 163305. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Herald added a subscriber: arphaman. - Fix the `.py` (should be `.el` in the second case) typo - Move piece about rename request to Clangd docs and advertise it htere - Use better wo

[PATCH] D51292: [docs] Update clang-rename documentation

ioeric added inline comments. Comment at: clang-tools-extra/docs/clang-rename.rst:140 + +:program:`clangd `_ uses +:program:`clang-rename` infrastructure to handle renaming requests. Currently, nit: `clangd *shares* the r

[PATCH] D51292: [docs] Update clang-rename documentation

ilya-biryukov added a comment. Leaving some comments, but also suggest getting the final LGTM from the owner of the doc (@ioeric?) Comment at: clang-tools-extra/docs/clang-rename.rst:141 +:program:`clangd `_ uses +:program:`clang-renam

[PATCH] D51292: [docs] Update clang-rename documentation

kbobyrev updated this revision to Diff 163025. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Moved the note about Clangd integration to the end, rephrased a bit. https://reviews.llvm.org/D51292 Files: clang-tools-extra/docs/clang-rename.rst Index: clang-tools-extra/do

[PATCH] D51292: [docs] Update clang-rename documentation

ilya-biryukov added inline comments. Comment at: clang-tools-extra/docs/clang-rename.rst:28 +:program:`clang-rename` infrastructure to handle renaming requests. Because of +much better editor integration and support, it is advised to use +:program:`clangd-rename` as part of :prog

[PATCH] D51292: [docs] Update clang-rename documentation

kbobyrev added inline comments. Comment at: clang-tools-extra/docs/clang-rename.rst:28 +:program:`clang-rename` infrastructure to handle renaming requests. Because of +much better editor integration and support, it is advised to use +:program:`clangd-rename` as part of :program:`

[PATCH] D51292: [docs] Update clang-rename documentation

ilya-biryukov added inline comments. Comment at: clang-tools-extra/docs/clang-rename.rst:28 +:program:`clang-rename` infrastructure to handle renaming requests. Because of +much better editor integration and support, it is advised to use +:program:`clangd-rename` as part of :prog