This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE340409: [clangd] Implement BOOST iterator (authored by
omtcyfz, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50970?vs=161936&id=161944#toc
Repository:
rCTE Clang Tools Extra
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D50970
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
kbobyrev updated this revision to Diff 161936.
kbobyrev marked 2 inline comments as done.
kbobyrev added a comment.
Address remaining comments.
https://reviews.llvm.org/D50970
Files:
clang-tools-extra/clangd/index/dex/DexIndex.cpp
clang-tools-extra/clangd/index/dex/Iterator.cpp
clang-tool
ilya-biryukov added a comment.
Summarizing the offline discussion with @kbobyrev, @ioeric and @sammccall in
two comments.
Comment at: clang-tools-extra/clangd/index/dex/Iterator.h:96
+ /// shouldn't apply any boosting to the consumed item.
+ virtual float boost(DocID ID) con
kbobyrev updated this revision to Diff 161909.
kbobyrev marked 4 inline comments as done.
kbobyrev added a subscriber: sammccall.
kbobyrev added a comment.
- Add more comments explaining the difference between `consume()` and
`consumeAndBoost()` and their potential usecases for the clients
- Move
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Iterator.h:92
+ /// function, the parameter is needed to propagate through the tree.
+ virtual unsigned boost(DocID ID) const = 0;
Maybe add a note to the comment on why an `I
ilya-biryukov added a comment.
Looking at this one. (to make sure we don't clash with @ioeric)
Comment at: clang-tools-extra/clangd/index/dex/Iterator.h:111
+ const static unsigned DEFAULT_BOOST_SCORE;
+
Maybe make it `constexpr` and put the value into the h
kbobyrev updated this revision to Diff 161477.
kbobyrev retitled this revision from "[clangd] Introduce BOOST iterators" to
"[clangd] Implement BOOST iterator".
kbobyrev edited the summary of this revision.
kbobyrev added a comment.
Add documentation, cleanup tests.
https://reviews.llvm.org/D50
