This revision was automatically updated to reflect the committed changes.
Closed by commit rL340188: Close FileEntries of cached files in
ModuleManager::addModule(). (authored by adrian, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50870?vs=161119&id=161501#toc
Repository
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Thanks for working on this Adrian, LGTM.
> When we last discussed this my plan was to avoid the stat() in
> lookupModuleFile() for files that were just added to the PCMCache by
> WriteAST() ent
aprantl added a comment.
@bruno: When we last discussed this my plan was to avoid the stat() in
lookupModuleFile() for files that were just added to the PCMCache by WriteAST()
entirely, but ModuleManager::Modules is a DenseMap and
lookupModuleFile() is the easiest way to create a new FileEntry.
aprantl created this revision.
aprantl added reviewers: bruno, rsmith, teemperor.
Herald added a subscriber: llvm-commits.
Close FileEntries of cached files in ModuleManager::addModule().
While investigating why LLDB (which can build hundreds of clang
modules during one debug session) was getting
