[PATCH] D50852: abseil-auto-make-unique

2018-08-16 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added reviewers: aaron.ballman, zinovy.nis. lebedev.ri added a comment. In https://reviews.llvm.org/D50852#1203009, @hugoeg wrote: > In https://reviews.llvm.org/D50852#1202774, @lebedev.ri wrote: > > > 1. Please always upload all patches with full context. > > 2. There already is `mode

[PATCH] D50852: abseil-auto-make-unique

2018-08-16 Thread Hugo Gonzalez via Phabricator via cfe-commits
hugoeg added a comment. In https://reviews.llvm.org/D50852#1202774, @lebedev.ri wrote: > 1. Please always upload all patches with full context. > 2. There already is `modernize-use-auto`. Does it handle this case? Then this > should be just an alias to that check. Else, i think it would be best

[PATCH] D50852: abseil-auto-make-unique

2018-08-16 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In https://reviews.llvm.org/D50852#1202781, @hugoeg wrote: > what do you mean by "with full context"? `-U9` when generating the diff. https://reviews.llvm.org/D50852 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D50852: abseil-auto-make-unique

2018-08-16 Thread Hugo Gonzalez via Phabricator via cfe-commits
hugoeg added a comment. what do you mean by "with full context"? https://reviews.llvm.org/D50852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50852: abseil-auto-make-unique

2018-08-16 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. 1. Please always upload all patches with full context. 2. There already is `modernize-use-auto`. Does it handle this case? Then this should be just an alias to that check. Else, i think it would be best to extend that one, and still alias. https://reviews.llvm.org/D

[PATCH] D50852: abseil-auto-make-unique

2018-08-16 Thread Hugo Gonzalez via Phabricator via cfe-commits
hugoeg created this revision. hugoeg added reviewers: alexfh, hokein. hugoeg added a project: clang-tools-extra. Herald added a subscriber: mgorny. warns to use 'auto' to avoid repeating the type name and fixes the issue Replace: std::unique_ptr x = make_unique(...); with: auto x = make_uniqu