This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341146: Remove vestiges of configure buildsystem (authored
by steveire, committed by ).
Herald added a subscriber: llvm-co
steveire updated this revision to Diff 162283.
steveire added a comment.
Remove vestiges of configure buildsystem
Repository:
rC Clang
https://reviews.llvm.org/D50738
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMake
svenvh added inline comments.
Comment at: CMakeLists.txt:288
-if( CMAKE_SOURCE_DIR STREQUAL CMAKE_BINARY_DIR AND NOT MSVC_IDE )
- message(FATAL_ERROR "In-source builds are not allowed. CMake would overwrite
"
-"the makefiles distributed with LLVM. Please create a directory an
steveire created this revision.
Herald added subscribers: cfe-commits, mgorny.
Remove also the condition to allow in-source builds when using MSVC_IDE.
This may be vestigial and date from a time when llvm CMakeLists.txt had
a similar condition. The llvm file does not have such a condition, so
thi
