Dmitry.Kozhevnikov marked an inline comment as done.
Dmitry.Kozhevnikov added a comment.
In https://reviews.llvm.org/D50455#1193468, @ilya-biryukov wrote:
> Nevertheless, I think this is moving clangd in the right direction and if we
> see too many irrelevant errors, we should look into improvin
ilya-biryukov added a comment.
Herald added a subscriber: kadircet.
Sorry for the delay with this one
Comment at: unittests/clangd/ClangdTests.cpp:1002
+
+ auto MainFileCI = buildCompilerInvocation(PI);
+ auto AST =
Just reuse `PreambleCI`?
Dmitry.Kozhevnikov added a comment.
In https://reviews.llvm.org/D50455#1193468, @ilya-biryukov wrote:
> I'm a bit worried that clang may emit too many irrelevant errors, because it
> may not cope nicely with those fatal errors, i.e. wasn't tested that
> thoroughly in that mode.
It sort of hap
Dmitry.Kozhevnikov updated this revision to Diff 160837.
Dmitry.Kozhevnikov added a comment.
Add a unit test which explicitly builds preamble/AST
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50455
Files:
clangd/ClangdUnit.cpp
clangd/Compiler.cpp
test/clangd/missing-incl
ilya-biryukov added a comment.
The new behavior looks reasonable for interactive tools like clangd, but I'm a
bit worried that clang may emit too many irrelevant errors, because it may not
cope nicely with those fatal errors, i.e. wasn't tested that thoroughly in that
mode.
Nevertheless, I thin
Dmitry.Kozhevnikov added a comment.
See also https://reviews.llvm.org/D50462
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Dmitry.Kozhevnikov created this revision.
Dmitry.Kozhevnikov added reviewers: ilya-biryukov, sammccall.
Herald added subscribers: cfe-commits, arphaman, jkorous.
By default, diagnostics are suppressed after a fatal error. Some fatal errors
(notably, "file not found" for include directive) are com
