[PATCH] D50170: [libcxxabi] Fix test_exception_address_alignment test for ARM

This revision was automatically updated to reflect the committed changes. Closed by commit rL339865: [libcxxabi] Fix test_exception_address_alignment test for ARM (authored by yroux, committed by ). Herald added a subscriber: christof. Changed prior to commit: https://reviews.llvm.org/D50170?vs

[PATCH] D50170: [libcxxabi] Fix test_exception_address_alignment test for ARM

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. It doesn't seem to get more reviewed than this. yroux, I'd say go ahead and commit it. Repository: rCXXA libc++abi https://reviews.llvm.org/D50170 __

[PATCH] D50170: [libcxxabi] Fix test_exception_address_alignment test for ARM

yroux added a comment. I dug a bit and can give more context. The usage of _LIBUNWIND_ARM_EHABI was introduced by https://reviews.llvm.org/D31178 but from what we are seeing with the release builds, libunwind headers are not picked up (at least in these configs) and since r309226

[PATCH] D50170: [libcxxabi] Fix test_exception_address_alignment test for ARM

hans added a comment. What do you other reviewers say? I'm not familiar with this code, but this seems reasonable to me. Repository: rCXXA libc++abi https://reviews.llvm.org/D50170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D50170: [libcxxabi] Fix test_exception_address_alignment test for ARM

mclow.lists added a comment. That certainly ***looks*** more correct to me. Repository: rCXXA libc++abi https://reviews.llvm.org/D50170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D50170: [libcxxabi] Fix test_exception_address_alignment test for ARM

yroux created this revision. yroux added reviewers: mclow.lists, hans. Herald added a reviewer: EricWF. Herald added a reviewer: javed.absar. Herald added subscribers: ldionne, chrib, kristof.beyls. Check _LIBCXXABI_ARM_EHABI macro instead of libunwind version Repository: rCXXA libc++abi http