[PATCH] D50029: [COFF, ARM64] Enable SEH for ARM64 Windows

2018-07-31 Thread Mandeep Singh Grang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL338405: [COFF, ARM64] Enable SEH for ARM64 Windows (authored by mgrang, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50029?vs=158147&id=158

[PATCH] D50029: [COFF, ARM64] Enable SEH for ARM64 Windows

2018-07-30 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D50029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50029: [COFF, ARM64] Enable SEH for ARM64 Windows

2018-07-30 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang updated this revision to Diff 158147. mgrang added a comment. Addressed comments. https://reviews.llvm.org/D50029 Files: include/clang/Basic/TargetInfo.h test/CodeGen/exceptions-seh-finally.c test/CodeGen/exceptions-seh.c Index: test/CodeGen/exceptions-seh.c =

[PATCH] D50029: [COFF, ARM64] Enable SEH for ARM64 Windows

2018-07-30 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: test/CodeGen/exceptions-seh.c:10 +// RUN: %clang_cc1 %s -triple aarch64-windows -fms-extensions -emit-llvm -o - \ +// RUN: | FileCheck %s --check-prefix=X64-GNU mgrang wrote: > Is it OK to re-use the X64-GNU check

[PATCH] D50029: [COFF, ARM64] Enable SEH for ARM64 Windows

2018-07-30 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang added inline comments. Comment at: test/CodeGen/exceptions-seh.c:10 +// RUN: %clang_cc1 %s -triple aarch64-windows -fms-extensions -emit-llvm -o - \ +// RUN: | FileCheck %s --check-prefix=X64-GNU Is it OK to re-use the X64-GNU check prefix here o

[PATCH] D50029: [COFF, ARM64] Enable SEH for ARM64 Windows

2018-07-30 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang created this revision. mgrang added reviewers: rnk, mstorsjo, ssijaric, haripul, TomTan. Herald added subscribers: chrib, kristof.beyls. Repository: rC Clang https://reviews.llvm.org/D50029 Files: include/clang/Basic/TargetInfo.h test/CodeGen/exceptions-seh-finally.c test/CodeGen/