[PATCH] D49143: Fix a typo/regression in r335495.

2018-07-10 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC336710: Fix a typo/regression in r335495. (authored by jhb, committed by ). Changed prior to commit: https://reviews.llvm.org/D49143?vs=154840&id=154845#toc Repository: rC Clang https://reviews.llvm

[PATCH] D49143: Fix a typo/regression in r335495.

2018-07-10 Thread Simon Atanasyan via Phabricator via cfe-commits
atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D49143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D49143: Fix a typo/regression in r335495.

2018-07-10 Thread John Baldwin via Phabricator via cfe-commits
bsdjhb updated this revision to Diff 154840. bsdjhb added a comment. Add tests. Repository: rC Clang https://reviews.llvm.org/D49143 Files: lib/Driver/ToolChains/FreeBSD.cpp test/Driver/fsanitize.c Index: test/Driver/fsanitize.c =

[PATCH] D49143: Fix a typo/regression in r335495.

2018-07-10 Thread John Baldwin via Phabricator via cfe-commits
bsdjhb added a comment. AFAICT, I don't see a way to ask clang "which sanitizers are supported by this target". Hmm, the CHECK-SANL-MIPS test in tests/Driver/fsanitize.c seems like the closest match. Repository: rC Clang https://reviews.llvm.org/D49143 __

[PATCH] D49143: Fix a typo/regression in r335495.

2018-07-10 Thread Simon Atanasyan via Phabricator via cfe-commits
atanasyan added a comment. It would be nice to have a test for this regression. Repository: rC Clang https://reviews.llvm.org/D49143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D49143: Fix a typo/regression in r335495.

2018-07-10 Thread John Baldwin via Phabricator via cfe-commits
bsdjhb created this revision. bsdjhb added a reviewer: arichardson. Herald added subscribers: atanasyan, krytarowski, sdardis, emaste. Use getTriple.isMIPS64() to detect 64-bit MIPS ABIs in FreeBSD::getSupportedSanitizers() instead of getTriple.isMIPS32(). Repository: rC Clang https://reviews