[PATCH] D48961: [Index] Add indexing support for MACROs.

marcobubke added a comment. Herald added a subscriber: dexonsmith. Herald added a project: clang. This changset is not handling #ifdef MACRO, defined(MACRO) etc. in he PPCallbacks. Is there any intention to omit them or do you simply forgot them? Repository: rC Clang CHANGES SINCE LAST ACTIO

[PATCH] D48961: [Index] Add indexing support for MACROs.

This revision was automatically updated to reflect the committed changes. Closed by commit rC336524: [Index] Add indexing support for MACROs. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D48961?vs=154543&id=154550#toc Repository: rC Clang https://re

[PATCH] D48961: [Index] Add indexing support for MACROs.

ioeric updated this revision to Diff 154543. ioeric marked 2 inline comments as done. ioeric added a comment. - addressed review comments. Repository: rC Clang https://reviews.llvm.org/D48961 Files: include/clang/Index/IndexSymbol.h include/clang/Index/IndexingAction.h lib/Index/IndexS

[PATCH] D48961: [Index] Add indexing support for MACROs.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Index/IndexDataConsumer.h:48 /// \returns true to continue indexing, or false to abort. - virtual bool handleMacroOccurence(const Iden

[PATCH] D48961: [Index] Add indexing support for MACROs.

ioeric updated this revision to Diff 154390. ioeric added a comment. - removed Undefined parameter. Repository: rC Clang https://reviews.llvm.org/D48961 Files: include/clang/Index/IndexDataConsumer.h include/clang/Index/IndexSymbol.h include/clang/Index/IndexingAction.h lib/Index/Ind

[PATCH] D48961: [Index] Add indexing support for MACROs.

ioeric updated this revision to Diff 154388. ioeric marked 6 inline comments as done. ioeric added a comment. - addressed review comments. Repository: rC Clang https://reviews.llvm.org/D48961 Files: include/clang/Index/IndexDataConsumer.h include/clang/Index/IndexSymbol.h include/clang

[PATCH] D48961: [Index] Add indexing support for MACROs.

ioeric added inline comments. Comment at: include/clang/Index/IndexDataConsumer.h:48 /// \returns true to continue indexing, or false to abort. - virtual bool handleMacroOccurence(const IdentifierInfo *Name, -const MacroInfo *MI, SymbolRole

[PATCH] D48961: [Index] Add indexing support for MACROs.

sammccall added inline comments. Comment at: include/clang/Index/IndexDataConsumer.h:48 /// \returns true to continue indexing, or false to abort. - virtual bool handleMacroOccurence(const IdentifierInfo *Name, -const MacroInfo *MI, SymbolR

[PATCH] D48961: [Index] Add indexing support for MACROs.

ioeric added a comment. Thanks for the review! In https://reviews.llvm.org/D48961#1152999, @sammccall wrote: > I worry this is a trap: the indexing infrastructure here is designed so you > can run it as a frontendaction, on an ASTUnit, or by passing a set of top > level decls. > However the m

[PATCH] D48961: [Index] Add indexing support for MACROs.

ioeric updated this revision to Diff 154367. ioeric marked 2 inline comments as done. ioeric added a comment. - Addressed review comments. Expose create a PPCallbacks for indexing macros. Repository: rC Clang https://reviews.llvm.org/D48961 Files: include/clang/Index/IndexDataConsumer.h

[PATCH] D48961: [Index] Add indexing support for MACROs.

sammccall added a comment. I worry this is a trap: the indexing infrastructure here is designed so you can run it as a frontendaction, on an ASTUnit, or by passing a set of top level decls. However the macro functionality necessarily only works when running as a frontend action, so the same con

[PATCH] D48961: [Index] Add indexing support for MACROs.

ioeric created this revision. ioeric added reviewers: akyrtzi, arphaman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D48961 Files: include/clang/Index/IndexDataConsumer.h include/clang/Index/IndexSymbol.h lib/Index/IndexSymbol.cpp lib/Index/Ind