This revision was automatically updated to reflect the committed changes.
Closed by commit rL336604: Added -fcrash-diagnostics-dir flag (authored by
inglorion, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48601?vs=153773&id=154695#toc
Repository:
rL LLVM
https://review
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D48601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
j10kay updated this revision to Diff 153773.
j10kay marked 3 inline comments as done.
j10kay added a comment.
Implemented the code review changes
Repository:
rL LLVM
https://reviews.llvm.org/D48601
Files:
clang/include/clang/Driver/Options.td
clang/lib/Driver/Driver.cpp
clang/test/Driv
hans added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:4043-4044
+if (CCGenDiagnostics && A) {
+ SmallString<128> CrashDirectory;
+ CrashDirectory = A->getValue();
+ llvm::sys::path::append(CrashDirectory, Split.first);
zturner wro
zturner added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:4043-4044
+if (CCGenDiagnostics && A) {
+ SmallString<128> CrashDirectory;
+ CrashDirectory = A->getValue();
+ llvm::sys::path::append(CrashDirectory, Split.first);
Maybe yo
j10kay created this revision.
j10kay added reviewers: hans, inglorion, rnk.
Herald added subscribers: llvm-commits, hiraditya.
New flag causes crash reports to be written in the specified directory
rather than the temp directory.
Repository:
rL LLVM
https://reviews.llvm.org/D48601
Files:
c
