This revision was automatically updated to reflect the committed changes.
Closed by commit rC335420: [Sema] isValidCoroutineContext FIXME and citations
(authored by modocache, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48519?vs=152597&id=152598#toc
Repository:
rC Clan
modocache updated this revision to Diff 152597.
modocache added a comment.
Great, thanks for the review! I added a reference to N4499.
Repository:
rC Clang
https://reviews.llvm.org/D48519
Files:
lib/Sema/SemaCoroutine.cpp
test/SemaCXX/coroutines.cpp
Index: test/SemaCXX/coroutines.cpp
==
GorNishanov accepted this revision.
GorNishanov added a subscriber: rsmith.
GorNishanov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Sema/SemaCoroutine.cpp:260
else if (MD && MD->isMoveAssignmentOperator())
return DiagInvalid(Di
modocache added inline comments.
Comment at: lib/Sema/SemaCoroutine.cpp:260
else if (MD && MD->isMoveAssignmentOperator())
return DiagInvalid(DiagMoveAssign);
+ // [basic.start.main]p3: "The function main shall not be a coroutine."
@GorNishanov Is there
modocache added a comment.
Also @GorNishanov I'm curious about your two cents on whether comments like
these are valuable. If you think they are I may add a few more with post-commit
review.
Repository:
rC Clang
https://reviews.llvm.org/D48519
modocache created this revision.
modocache added reviewers: GorNishanov, EricWF.
Add citations to the Coroutines TS to the `isValidCoroutineContext`
function, as well as a FIXME and test for [expr.await]p2, which states
a co_await expression cannot be used in a default argument.
Test Plan: check-
