This revision was automatically updated to reflect the committed changes.
Closed by commit rC336275: [analyzer][ctu] fix unsortable diagnostics (authored
by r.stahl, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48474?vs=152433&id=154107#toc
Repository:
rC Clang
https:/
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
> My fear of using file IDs is that I don't know whether they are stable
IIRC they are currently stable, but that's relying on implementation details.
Still better than not
r.stahl added a comment.
In https://reviews.llvm.org/D30691#879838, @xazax.hun wrote:
> In https://reviews.llvm.org/D30691#878830, @r.stahl wrote:
>
> > For my purposes I replaced the return statement of the
> > compareCrossTUSourceLocs function with:
> >
> > return XL.getFileID() < YL.getFile
r.stahl created this revision.
r.stahl added reviewers: xazax.hun, NoQ, dcoughlin.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, rnkovacs,
szepet.
Herald added a reviewer: george.karpenkov.
In the provided test case the PathDiagnostic compare function was not able to
find a
