aheejin marked an inline comment as done.
aheejin added inline comments.
Comment at: lib/CodeGen/CGException.cpp:322
const EHPersonality &CXX =
- getCXXPersonality(getTarget().getTriple(), LangOpts);
+ getCXXPersonality(getTarget().getTriple(), LangOpts, getTarget())
sbc100 added inline comments.
Comment at: lib/CodeGen/CGException.cpp:322
const EHPersonality &CXX =
- getCXXPersonality(getTarget().getTriple(), LangOpts);
+ getCXXPersonality(getTarget().getTriple(), LangOpts, getTarget());
if (&ObjCXX == &CXX)
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333716: [WebAssembly] Hide new Wasm EH behind its feature
flag (authored by aheejin, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47614?vs=149386&id=149387#toc
Repository:
rC Cl
aheejin updated this revision to Diff 149386.
aheejin added a comment.
- Add a missing conditional statement. I'll still assume this as accepted
Repository:
rC Clang
https://reviews.llvm.org/D47614
Files:
lib/CodeGen/CGException.cpp
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/wasm-eh
aheejin created this revision.
aheejin added reviewers: dschuff, majnemer.
Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100.
clang's current wasm EH implementation is a non-MVP feature in progress.
We had a `-mexception-handling` wasm feature but were not using it. This
pat