This revision was automatically updated to reflect the committed changes.
yaxunl marked 3 inline comments as done.
Closed by commit rC334128: [HIP] Fix unbundling (authored by yaxunl, committed
by ).
Changed prior to commit:
https://reviews.llvm.org/D47555?vs=149191&id=150188#toc
Repository:
yaxunl marked 3 inline comments as done.
yaxunl added inline comments.
Comment at: lib/Driver/Driver.cpp:3895
+if (UI.DependentOffloadKind == Action::OFK_Host)
+ Arch = StringRef();
+else
tra wrote:
> Should it be something more descripti
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
Few minor nits/suggestions. LGTM otherwise.
Comment at: lib/Driver/Driver.cpp:3895
+if (UI.DependentOffloadKind == Action::OFK_Host)
+ Arch = StringRef();
+
yaxunl created this revision.
yaxunl added a reviewer: rjmccall.
HIP uses clang-offload-bundler to bundle intermediate files for host
and different gpu archs together. When a file is unbundled,
clang-offload-bundler should be called only once, and the objects
for host and different gpu archs shoul
