[PATCH] D47358: : Implement {un,}synchronized_pool_resource.

Quuxplusone abandoned this revision. Quuxplusone added a comment. Superseded by D89057 . Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47358/new/ https://reviews.llvm.org/D47358 ___

[PATCH] D47358: : Implement {un,}synchronized_pool_resource.

Quuxplusone updated this revision to Diff 219758. Quuxplusone added a comment. Rebased on master. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47358/new/ https://reviews.llvm.org/D47358 Files: include/experimental/memory_resource src/experimental/memory_

[PATCH] D47358: : Implement {un,}synchronized_pool_resource.

Quuxplusone updated this revision to Diff 196699. Quuxplusone added a comment. Add tests that `LIBCPP_ASSERT_NOEXCEPT` the `options` and `upstream_resource` accessors. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47358/new/ https://reviews.llvm.org/D47358 F

[PATCH] D47358: : Implement {un,}synchronized_pool_resource.

mclow.lists added a comment. In D47358#1438929 , @Quuxplusone wrote: > Rebased. Added `_NOEXCEPT` to `upstream_resource()` and `options()` (this is > OK per [res.on.exception.handling]/5). That's fine, but then we should have a test for that. We have th

[PATCH] D47358: : Implement {un,}synchronized_pool_resource.

Quuxplusone updated this revision to Diff 196575. Quuxplusone added a comment. Rebased on D47111 . Replaced all instances of `__release` with `__release_ptr`, to match what @EricWF did in https://github.com/llvm-mirror/libcxx/commit/8e365750a0299ee0cbef70a3f3492c

[PATCH] D47358: : Implement {un,}synchronized_pool_resource.

Quuxplusone updated this revision to Diff 191815. Quuxplusone added a comment. Herald added a subscriber: jdoerfert. Rebased. Added `_NOEXCEPT` to `upstream_resource()` and `options()` (this is OK per [res.on.exception.handling]/5). Repository: rCXX libc++ CHANGES SINCE LAST ACTION https:/

[PATCH] D47358: : Implement {un, }synchronized_pool_resource.

Quuxplusone updated this revision to Diff 185233. Quuxplusone added a subscriber: AlisdairM. Quuxplusone added a comment. Rebased on master. @EricWF (cc @AlisdairM) ping! Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47358/new/ https://reviews.llvm.org/D47358

[PATCH] D47358: : Implement {un, }synchronized_pool_resource.

Quuxplusone updated this revision to Diff 175011. Quuxplusone added a comment. Change `1 <<` to `size_t(1) <<` in one last place. @EricWF ping. Repository: rCXX libc++ https://reviews.llvm.org/D47358 Files: include/experimental/memory_resource src/experimental/memory_resource.cpp test

[PATCH] D47358: : Implement {un, }synchronized_pool_resource.

Quuxplusone updated this revision to Diff 173613. Quuxplusone added a comment. Herald added a subscriber: libcxx-commits. Rebased on master. @ericwf @ldionne ping please? Repository: rCXX libc++ https://reviews.llvm.org/D47358 Files: include/experimental/memory_resource src/experimental/

[PATCH] D47358: : Implement {un, }synchronized_pool_resource.

Quuxplusone updated this revision to Diff 155791. Quuxplusone added a comment. Implement similar cosmetic cleanup to https://reviews.llvm.org/D47111, but for the pool resources this time. I think the argument for keeping do_allocate and do_deallocate in the .cpp file is stronger for these guys t

[PATCH] D47358: : Implement {un, }synchronized_pool_resource.

Quuxplusone updated this revision to Diff 153882. Herald added subscribers: ldionne, christof. Repository: rCXX libc++ https://reviews.llvm.org/D47358 Files: include/experimental/memory_resource src/experimental/memory_resource.cpp test/libcxx/experimental/memory/memory.resource.pool/me

[PATCH] D47358: : Implement {un, }synchronized_pool_resource.

Quuxplusone updated this revision to Diff 151984. Quuxplusone added a comment. Herald added a subscriber: mgrang. Bugfix and shrink {un,}synchronized_pool_resource. The old implementation was severely broken in two ways: - It accidentally sometimes trusted the user's `bytes` and `align` argument

[PATCH] D47358: : Implement {un, }synchronized_pool_resource.

Quuxplusone planned changes to this revision. Quuxplusone added inline comments. Comment at: src/experimental/memory_resource.cpp:240 +bool allocation_contains(const char *p) const { +// TODO: This part technically relies on undefined behavior. +return allocat

[PATCH] D47358: : Implement {un, }synchronized_pool_resource.

Quuxplusone updated this revision to Diff 149611. Quuxplusone added a comment. - Split up the unit tests. - Refactor to shrink the memory layout of the resource object itself. Before this patch `sizeof(unsynchronized_pool_resource)==48`. After this patch `sizeof(unsynchronized_pool_resource) ==

[PATCH] D47358: : Implement {un, }synchronized_pool_resource.

Quuxplusone added inline comments. Comment at: test/std/experimental/memory/memory.resource.pool/pool_options.pass.cpp:11 +// UNSUPPORTED: c++98, c++03, c++11, c++14 +// UNSUPPORTED: apple-clang-7 + This test comes from Eric's D27402. The default-initialization

[PATCH] D47358: : Implement {un, }synchronized_pool_resource.

Quuxplusone updated this revision to Diff 149006. Quuxplusone added a comment. Rebase and update the diff. Repository: rCXX libc++ https://reviews.llvm.org/D47358 Files: include/experimental/memory_resource src/experimental/memory_resource.cpp test/std/experimental/memory/memory.resour

[PATCH] D47358: : Implement {un, }synchronized_pool_resource.

Quuxplusone created this revision. Quuxplusone added a reviewer: EricWF. Herald added a subscriber: cfe-commits. Split out from https://reviews.llvm.org/D47090. This patch is based on top of (depends on) https://reviews.llvm.org/D47111, but I'm posting it now for review. Repository: rCXX libc