[PATCH] D47101: [Sema] Use %sub to cleanup overload diagnostics

2018-05-29 Thread Eric Fiselier via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL333485: [Sema] Use %sub to cleanup overload diagnostics (authored by EricWF, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D47101?vs=147649&i

[PATCH] D47101: [Sema] Use %sub to cleanup overload diagnostics

2018-05-29 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Actually I'm OK making this a post-commit review. @rsmith Please let me know if you have any thoughts in your own time. Repository: rC Clang https://reviews.llvm.org/D47101

[PATCH] D47101: [Sema] Use %sub to cleanup overload diagnostics

2018-05-29 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. @rsmith Ping. Do you have any objection to the addition of "template" to some of the overload diagnostics? Repository: rC Clang https://reviews.llvm.org/D47101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D47101: [Sema] Use %sub to cleanup overload diagnostics

2018-05-18 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF created this revision. EricWF added a reviewer: rsmith. This patch adds the newly added `%sub` diagnostic modifier to cleanup repetition in the overload candidate diagnostics. I think this should be good to go. @rsmith: Some of the notes now emit `function template` where they only said