Re: [PATCH] D46964: Implement class deduction guides for `std::array`

2018-05-24 Thread Yvan Roux via cfe-commits
Hi Marshall, ARM and AArch64 libcxx buildbots are broken since that commits, logs are available at: http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv7-linux/builds/107/steps/test.libcxx/logs/FAIL%3A%20libc%2B%2B%3A%3Adeduct.pass.cpp Thanks Yvan On 18 May 2018 at 23:05, Marshall

[PATCH] D46964: Implement class deduction guides for `std::array`

2018-05-18 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists closed this revision. mclow.lists added a comment. Committed as revision 332768 https://reviews.llvm.org/D46964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46964: Implement class deduction guides for `std::array`

2018-05-18 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists added inline comments. Comment at: include/array:75 + template +array(T, U...) -> array; EricWF wrote: > Don't we normally comment `// C++17` or similar for new features in the > synopsis? we do. Comment at: include/array:3

[PATCH] D46964: Implement class deduction guides for `std::array`

2018-05-18 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added inline comments. This revision is now accepted and ready to land. Comment at: include/array:75 + template +array(T, U...) -> array; Don't we normally comment `// C++17` or similar for new features in the synops

[PATCH] D46964: Implement class deduction guides for `std::array`

2018-05-16 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists created this revision. mclow.lists added a reviewer: EricWF. According to http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0433r2.html Once this is reviewed, I'll do the rest of the sequence containers. https://reviews.llvm.org/D46964 Files: include/array test/std/cont