martong added a comment.
@a.sidorin
Yes, that is a very good idea.
Just created a new patch which adds that switch for the tests which use the
TestBase.
https://reviews.llvm.org/D47367
Repository:
rC Clang
https://reviews.llvm.org/D46950
___
cf
a.sidorin added a comment.
Hm. Should we test `-fms-compatibility` in addition to
`-fdelayed-template-parsing`?
Repository:
rC Clang
https://reviews.llvm.org/D46950
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333082: Fix duplicate class template definitions problem
(authored by martong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46950?vs=148013&id=148204#toc
Repository:
rC Clang
h
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rC Clang
https://reviews.llvm.org/D46950
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
martong updated this revision to Diff 148013.
martong marked 5 inline comments as done.
martong added a comment.
- Addressing Aleksei's comments
Repository:
rC Clang
https://reviews.llvm.org/D46950
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
unittests/AST/DeclMatch
a.sidorin added a comment.
Hello Gabor,
The patch is fine, I have found only some style issues.
Comment at: lib/AST/ASTImporter.cpp:4073
+// Returns the definition for a (forwad) declaration of a ClassTemplateDecl, if
+// it has any definition in the redecl chain.
--
