thakis added a comment.
> Sorry about the breakage, I wasn't aware of that test failure and never got
> any email (probably because the bot has been red before). I'll try to fix
> make_itanium_abi_triple and test it on my Windows box tomorrow before
> resubmitting.
Thanks, sounds good. Reading
phosek added a comment.
In https://reviews.llvm.org/D46910#1105992, @thakis wrote:
> This changes the default triple on Windows from x86_64-pc-win32 to
> x86_64-pc-windows-msvc. This breaks at least lit's make_itanium_abi_triple()
> (http://llvm-cs.pcc.me.uk/utils/lit/lit/llvm/config.py#234)
>
thakis added a comment.
Reverted in r332822 / r332823.
Repository:
rC Clang
https://reviews.llvm.org/D46910
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis added a comment.
…hm looks like https://reviews.llvm.org/rL332750 touched files in both clang
and llvm, which is probably why the diff looks super confusing on phab. I'll
revert it in two pieces, I don't know how to commit changes to llvm and clang
in one revision.
Repository:
rC Cla
thakis added a comment.
This changes the default triple on Windows from x86_64-pc-win32 to
x86_64-pc-windows-msvc. This breaks at least lit's make_itanium_abi_triple()
(http://llvm-cs.pcc.me.uk/utils/lit/lit/llvm/config.py#234)
def make_itanium_abi_triple(self, triple):
m = re.match(r'(
thakis added a comment.
(sorry, hit cmd-return accidentally, I will come in again…)
Repository:
rC Clang
https://reviews.llvm.org/D46910
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
thakis added a comment.
This changes the default triple on Windows from x86_64-pc-win32 to
x86_64-pc-windows-msvc. This breaks at least
Repository:
rC Clang
https://reviews.llvm.org/D46910
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rC332750: [Support] Avoid normalization in
sys::getDefaultTargetTriple (authored by phosek, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46910?vs=147431&id=147567#toc
Repository:
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D46910
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
phosek added a comment.
Applied, thanks so much for looking into it.
Repository:
rC Clang
https://reviews.llvm.org/D46910
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
phosek updated this revision to Diff 147431.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D46910
Files:
clang/lib/Frontend/CompilerInvocation.cpp
llvm/cmake/modules/GetHostTriple.cmake
llvm/lib/Support/Unix/Host.inc
llvm/lib/Support/Windows/Host
11 matches
Mail list logo
