george.karpenkov added a comment.
> Not sure yet whether i will land them right away, or wait for clang-tidy part.
I think it's better to land, as otherwise you risk merge conflicts, and
implicit conflicts (git reports no errors, but the resulting code is bad) can
be very annoying.
Repository
lebedev.ri added a comment.
In https://reviews.llvm.org/D46603#1101047, @lebedev.ri wrote:
> In https://reviews.llvm.org/D46603#1100455, @george.karpenkov wrote:
>
> > I see four separate changes: s/.sys/mem one (can be committed without
> > review), exposing printJSONValues and consequent addin
lebedev.ri abandoned this revision.
lebedev.ri added a comment.
In https://reviews.llvm.org/D46603#1100455, @george.karpenkov wrote:
> I see four separate changes: s/.sys/mem one (can be committed without
> review), exposing printJSONValues and consequent adding of a lock, adding a
> constructo
george.karpenkov added a comment.
I see four separate changes: s/.sys/mem one (can be committed without review),
exposing printJSONValues and consequent adding of a lock, adding a constructor
accepting a map, and fixing formatting in `printJSONValue`. All four look good
to me, but probably shou
lebedev.ri added a comment.
Ping.
Any thoughts on these Timer changes?
Repository:
rL LLVM
https://reviews.llvm.org/D46603
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lebedev.ri updated this revision to Diff 145994.
lebedev.ri added a comment.
- Use sane (not the same as the one right before..) suffix for when
json-printing mem usage. Admittedly, i haven't tried it, but it just does not
make sense otherwise.
Repository:
rL LLVM
https://reviews.llvm.org/D
alexfh added a comment.
I wonder why JSON? What kind of a tool do folks use to process the outputs of
printJSONValue? Is there anything existing or is JSON used "just in case"? I
personally use either spreadsheets, python or shell when I deal with this kind
of data, and all three of them can wo
lebedev.ri updated this revision to Diff 145903.
lebedev.ri added a comment.
Add lock to now-public `printJSONValues()`.
I have no understanding of the `static TimerGroupList`,
but this is symmetrical with other [public] `TimerGroup::*print*` methods.
Repository:
rL LLVM
https://reviews.llvm
lebedev.ri updated this revision to Diff 145900.
lebedev.ri retitled this revision from "[Support] Print TimeRecord as CSV" to
"[Support] TimerGroup changes".
lebedev.ri edited the summary of this revision.
lebedev.ri added a reviewer: NoQ.
lebedev.ri added subscribers: xazax.hun, szepet, a.sidori
