This revision was automatically updated to reflect the committed changes.
Closed by commit rL334101: [clang-tidy] Store checks profiling info as JSON
files (authored by lebedevri, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46602?vs=149933&id=150142#toc
Repository:
rL
lebedev.ri added a comment.
In https://reviews.llvm.org/D46602#1123631, @alexfh wrote:
> LG
Thank you for the review!
Repository:
rL LLVM
https://reviews.llvm.org/D46602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
https://reviews.llvm.org/D46602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
lebedev.ri added a comment.
In https://reviews.llvm.org/D46602#1122194, @aaron.ballman wrote:
> LGTM!
Thank you for the review.
Waiting on @alexfh ...
Repository:
rL LLVM
https://reviews.llvm.org/D46602
___
cfe-commits mailing list
cfe-commit
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM!
Comment at: clang-tidy/ClangTidyProfiling.cpp:47
+void ClangTidyProfiling::printAsJSON(llvm::raw_ostream &OS) {
+ OS << "{\n";
lebedev.ri wrote:
> aaron.ballman wrote:
> > I'm not kee
lebedev.ri added inline comments.
Comment at: clang-tidy/ClangTidyProfiling.cpp:47
+void ClangTidyProfiling::printAsJSON(llvm::raw_ostream &OS) {
+ OS << "{\n";
aaron.ballman wrote:
> I'm not keen that we call this `printAsJSON()` when the docs talk about
> w
lebedev.ri updated this revision to Diff 149933.
lebedev.ri marked 5 inline comments as done.
lebedev.ri added a comment.
Rebase ontop of https://reviews.llvm.org/rL333994, address review notes,
canonicalize to `JSON`.
Repository:
rL LLVM
https://reviews.llvm.org/D46602
Files:
clang-tidy/
