This revision was automatically updated to reflect the committed changes.
Closed by commit rL332123: [HIP] Set proper triple and offload kind for the
toolchain (authored by yaxunl, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D46475?
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
https://reviews.llvm.org/D46475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
yaxunl updated this revision to Diff 145699.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Revised by John's comments.
https://reviews.llvm.org/D46475
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Options.td
include/clang/Driver/Types.h
lib/
rjmccall added inline comments.
Comment at: lib/Driver/Driver.cpp:554
+ }) ||
+ IsHIP) {
const ToolChain *HostTC = C.getSingleOffloadToolChain();
It seems to me that it wouldn't be too hard to do your TODO here; it's
basically just ch
yaxunl created this revision.
yaxunl added reviewers: rjmccall, tra.
Also introduce --hip-link option to indicate HIP for linking.
https://reviews.llvm.org/D46475
Files:
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
