[PATCH] D46443: Add missing cstdalign header

sbc100 updated this revision to Diff 328561. sbc100 added a comment. feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46443/new/ https://reviews.llvm.org/D46443 Files: libcxx/include/CMakeLists.txt libcxx/include/cstdalign libcxx/inclu

[PATCH] D46443: Add missing cstdalign header

sbc100 updated this revision to Diff 328557. sbc100 marked 2 inline comments as done. sbc100 added a comment. feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46443/new/ https://reviews.llvm.org/D46443 Files: libcxx/include/CMakeLists.txt

[PATCH] D46443: Add missing cstdalign header

sbc100 marked 2 inline comments as done. sbc100 added inline comments. Comment at: libcxx/test/std/language.support/cstdalign/cstdalign.pass.cpp:14-28 +#ifdef alignas +#error alignas should not be a macro in C++ +#endif + +#ifdef alignof +#error alignof should not be a macro in C

[PATCH] D46443: Add missing cstdalign header

ldionne requested changes to this revision. ldionne added inline comments. This revision now requires changes to proceed. Comment at: libcxx/test/std/language.support/cstdalign/cstdalign.pass.cpp:8 +//===--===//

[PATCH] D46443: Add missing cstdalign header

sbc100 updated this revision to Diff 328538. sbc100 added a comment. add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46443/new/ https://reviews.llvm.org/D46443 Files: libcxx/include/CMakeLists.txt libcxx/include/cstdalign libcxx/incl

[PATCH] D46443: Add missing cstdalign header

sbc100 added inline comments. Comment at: libcxx/include/cstdalign:19-22 + alignof + alignas +__alignof_is_defined +__alignas_is_defined curdeius wrote: > You should test that each of these macros is really defined when including > `cstdalign`. Done.

[PATCH] D46443: Add missing cstdalign header

sbc100 added inline comments. Comment at: libcxx/test/libcxx/utilities/any/size_and_alignment.pass.cpp:16 #include +#include curdeius wrote: > This doesn't seem to be necessary. Or? > In C++, `alignof` is a keyword. You are right its not necessary in C++ sin

[PATCH] D46443: Add missing cstdalign header

curdeius added inline comments. Comment at: libcxx/include/cstdalign:19-22 + alignof + alignas +__alignof_is_defined +__alignas_is_defined You should test that each of these macros is really defined when including `cstdalign`. Comm

[PATCH] D46443: Add missing cstdalign header

sbc100 updated this revision to Diff 328524. sbc100 added a comment. Herald added a subscriber: mgorny. feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46443/new/ https://reviews.llvm.org/D46443 Files: libcxx/include/CMakeLists.txt libc

[PATCH] D46443: Add missing cstdalign header

sbc100 updated this revision to Diff 328522. sbc100 added a comment. Herald added a project: libc++. Herald added a reviewer: libc++. Rebase against mono-repo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46443/new/ https://reviews.llvm.org/D46443

[PATCH] D46443: Add missing cstdalign header

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. In D46443#2566394 , @hubert.reinterpretcast wrote: > The resolution of LWG 2828 > m

[PATCH] D46443: Add missing cstdalign header

hubert.reinterpretcast added a comment. Herald added a subscriber: wingo. The resolution of LWG 2828 means that `` exists in C++11 and C++14. The rationale from https://reviews.llvm.org/D96786#2566110 can be taken as saying that adding this

[PATCH] D46443: Add missing cstdalign header

ldionne added a subscriber: mclow.lists. ldionne added a comment. I believe this header has been deprecated. According to http://eel.is/c++draft/diff.cpp17.library, the effect of this header is nothing. @mclow.lists can you chime in? Repository: rCXX libc++ https://reviews.llvm.org/D46443

[PATCH] D46443: Add missing cstdalign header

sbc100 added a comment. ping Repository: rCXX libc++ https://reviews.llvm.org/D46443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46443: Add missing cstdalign header

sbc100 updated this revision to Diff 145247. sbc100 added a comment. - revert Repository: rCXX libc++ https://reviews.llvm.org/D46443 Files: include/cstdalign test/libcxx/min_max_macros.sh.cpp test/libcxx/utilities/any/size_and_alignment.pass.cpp Index: test/libcxx/utilities/any/size

[PATCH] D46443: Add missing cstdalign header

sbc100 created this revision. Herald added subscribers: cfe-commits, christof, aheejin. Repository: rCXX libc++ https://reviews.llvm.org/D46443 Files: include/cassert include/cstdalign test/libcxx/min_max_macros.sh.cpp test/libcxx/utilities/any/size_and_alignment.pass.cpp Index: test