[PATCH] D46281: [clang-doc] Attaching a name to reference data

2018-05-04 Thread Julie Hockett via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. juliehockett marked 2 inline comments as done. Closed by commit rL331539: [clang-doc] Attaching a name to reference data (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, klimek. Changed pri

[PATCH] D46281: [clang-doc] Attaching a name to reference data

2018-05-01 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added inline comments. Comment at: clang-doc/BitcodeWriter.cpp:382 + emitRecord(R.USR, REFERENCE_USR); + emitRecord(R.Name, REFERENCE_NAME); + emitRecord((unsigned)R.RefType, REFERENCE_TYPE); lebedev.ri wrote: > juliehockett wrote: > > lebedev.ri wr

[PATCH] D46281: [clang-doc] Attaching a name to reference data

2018-05-01 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. I can't really comment on the BC change since i don't think anything here makes use of that yet, but the code changes look ok to me. LGTM. Comment at: clang-doc/Bitc

[PATCH] D46281: [clang-doc] Attaching a name to reference data

2018-05-01 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett added inline comments. Comment at: clang-doc/BitcodeWriter.cpp:382 + emitRecord(R.USR, REFERENCE_USR); + emitRecord(R.Name, REFERENCE_NAME); + emitRecord((unsigned)R.RefType, REFERENCE_TYPE); lebedev.ri wrote: > >>! In D46281#1083806, @lebedev.ri

[PATCH] D46281: [clang-doc] Attaching a name to reference data

2018-05-01 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett updated this revision to Diff 144747. juliehockett marked 3 inline comments as done. juliehockett added a comment. Addressing a fixme and updating tests https://reviews.llvm.org/D46281 Files: clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/Representation.h c

[PATCH] D46281: [clang-doc] Attaching a name to reference data

2018-05-01 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added inline comments. Comment at: clang-doc/BitcodeWriter.cpp:382 + emitRecord(R.USR, REFERENCE_USR); + emitRecord(R.Name, REFERENCE_NAME); + emitRecord((unsigned)R.RefType, REFERENCE_TYPE); >>! In D46281#1083806, @lebedev.ri wrote: > Global questi

[PATCH] D46281: [clang-doc] Attaching a name to reference data

2018-05-01 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. Global question: you are using `NamedDecl::getNameAsString()`, and passing it as `StringRef`. You have looked at this with ASAN, and it's ok? Also, have you considered using the `NamedDecl::getName()`, which already returns `StringRef`.? Comment a

[PATCH] D46281: [clang-doc] Attaching a name to reference data

2018-04-30 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett updated this revision to Diff 144615. juliehockett marked 3 inline comments as done. juliehockett added a comment. Addressing comments https://reviews.llvm.org/D46281 Files: clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/Representation.h clang-doc/Serialize

[PATCH] D46281: [clang-doc] Attaching a name to reference data

2018-04-30 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added inline comments. Comment at: clang-doc/BitcodeWriter.cpp:275 +static SymbolID SID; void ClangDocBitcodeWriter::emitRecord(const SymbolID &Sym, RecordId ID) { 1. I'm not seeing where this is being changed? 2. This looks like some abstraction is

[PATCH] D46281: [clang-doc] Attaching a name to reference data

2018-04-30 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett created this revision. juliehockett added reviewers: sammccall, jakehehrlich, lebedev.ri. juliehockett added a project: clang-tools-extra. This adds the name of the referenced decl, in addition to its USR, to the saved data, so that the backend can look at an info in isolation and st