This revision was automatically updated to reflect the committed changes.
Closed by commit rL330861: [TargetInfo] Sort target features before passing
them to the backend (authored by efriedma, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm
fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.
Thanks Eli, LGTM!
Comment at: lib/Basic/Targets.cpp:641
Opts->Features.push_back((F.getValue() ? "+" : "-") + F.getKey().str());
+ llvm::sort(Opts->Features.begin(), Opts
efriedma updated this revision to Diff 143821.
efriedma added a comment.
Add REQUIRES line to testcase.
Repository:
rC Clang
https://reviews.llvm.org/D46030
Files:
lib/Basic/Targets.cpp
test/CodeGen/arm-build-attributes.c
Index: test/CodeGen/arm-build-attributes.c
=
efriedma created this revision.
efriedma added reviewers: fhahn, SjoerdMeijer.
Herald added a reviewer: javed.absar.
Herald added a subscriber: kristof.beyls.
Passing the features in random order will lead to unpredictable results when
some of the features are related (like the architecture-versi
