This revision was automatically updated to reflect the committed changes.
Closed by commit rL330871: [Driver] Fix implicit config files from prefixed
symlinks (authored by mstorsjo, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D45964
sepavloff added a comment.
In https://reviews.llvm.org/D45964#1077217, @mstorsjo wrote:
> Added an isEmpty() method.
This variant is more readable.
> Btw, did you see https://bugs.llvm.org/show_bug.cgi?id=37196? That one feels
> quite a bit more convolved so I don't really know (so far) how t
mstorsjo updated this revision to Diff 143794.
mstorsjo added a comment.
Added an isEmpty() method.
Btw, did you see https://bugs.llvm.org/show_bug.cgi?id=37196? That one feels
quite a bit more convolved so I don't really know (so far) how to approach
fixing that.
https://reviews.llvm.org/D45
sepavloff accepted this revision.
sepavloff added a comment.
This revision is now accepted and ready to land.
Thank you for fixing this issue!
LGTM
Comment at: lib/Driver/Driver.cpp:132
ArrayRef Args) {
- ClangNameParts = ToolChain::getTargetAndM
mstorsjo created this revision.
mstorsjo added reviewers: sepavloff, hfinkel, hans, rnk.
If -no-canonical-prefixes isn't used, the clang executable name used is the one
of the actual executable, not the name of the symlink that the user invoked.
In these cases, the target prefix was overridden
