This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330876: [analyzer] Enable analysis of WebKit "unified
sources". (authored by dergachev, committed by ).
Herald added a sub
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC330876: [analyzer] Enable analysis of WebKit "unified
sources". (authored by dergachev, committed by ).
Repository:
rC
probinson added a comment.
In https://reviews.llvm.org/D45839#1077258, @NoQ wrote:
> Aha, ok, yeah, that sounds like a lot, thank you. I think i'll follow up with
> a separate commit that will enable first-level-code-file-include analysis in
> all files under an on-by-default `-analyzer-config`
NoQ added a comment.
Aha, ok, yeah, that sounds like a lot, thank you. I think i'll follow up with a
separate commit that will enable first-level-code-file-include analysis in all
files under an on-by-default `-analyzer-config` flag, would that make sense?
https://reviews.llvm.org/D45839
__
probinson added inline comments.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:144
+// includes the full path.
+if (SM.getFilename(IL).contains("UnifiedSource")) {
+ StringRef Name = SM.getFilename(SL);
NoQ wrote:
> N
a.sidorin added a comment.
Hi Artem. Cool patch!
Maybe we should create an analyzer option for this? So, all users who want
webkit-like behaviour will just enable (or disable, don't know what's better)
the option and get the feature. I know that introducing a new option is
undesirable but it s
NoQ added inline comments.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:144
+// includes the full path.
+if (SM.getFilename(IL).contains("UnifiedSource")) {
+ StringRef Name = SM.getFilename(SL);
NoQ wrote:
> probins
NoQ added inline comments.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:144
+// includes the full path.
+if (SM.getFilename(IL).contains("UnifiedSource")) {
+ StringRef Name = SM.getFilename(SL);
probinson wrote:
> g
probinson added inline comments.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:144
+// includes the full path.
+if (SM.getFilename(IL).contains("UnifiedSource")) {
+ StringRef Name = SM.getFilename(SL);
george.karpenk
NoQ marked 2 inline comments as done.
NoQ added inline comments.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:145-147
+ if (Name.endswith_lower(".c") || Name.endswith_lower(".cpp") ||
+ Name.endswith_lower(".cc") || Name.endswith_lo
george.karpenkov added inline comments.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:144
+// includes the full path.
+if (SM.getFilename(IL).contains("UnifiedSource")) {
+ StringRef Name = SM.getFilename(SL);
NoQ wro
NoQ added inline comments.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:145-147
+ if (Name.endswith_lower(".c") || Name.endswith_lower(".cpp") ||
+ Name.endswith_lower(".cc") || Name.endswith_lower(".cxx") ||
+ Name.endswit
NoQ updated this revision to Diff 143416.
NoQ marked an inline comment as done.
NoQ added a comment.
A more accurate extension check.
https://reviews.llvm.org/D45839
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h
lib/StaticAnalyzer/Core/CallEvent.cpp
lib/StaticAn
majnemer added inline comments.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:145-147
+ if (Name.endswith_lower(".c") || Name.endswith_lower(".cpp") ||
+ Name.endswith_lower(".cc") || Name.endswith_lower(".cxx") ||
+ Name.en
NoQ added inline comments.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:144
+// includes the full path.
+if (SM.getFilename(IL).contains("UnifiedSource")) {
+ StringRef Name = SM.getFilename(SL);
george.karpenkov wro
NoQ updated this revision to Diff 143396.
NoQ marked 3 inline comments as done.
NoQ added a comment.
Address most comments.
https://reviews.llvm.org/D45839
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h
lib/StaticAnalyzer/Core/CallEvent.cpp
lib/StaticAnalyzer/Cor
george.karpenkov added inline comments.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:144
+// includes the full path.
+if (SM.getFilename(IL).contains("UnifiedSource")) {
+ StringRef Name = SM.getFilename(SL);
Is this
baloghadamsoftware added inline comments.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:148
+ Name.endswith_lower(".cc") || Name.endswith_lower(".m") ||
+ Name.endswith_lower(".mm")) {
+return true;
Altho
NoQ updated this revision to Diff 143195.
NoQ added a comment.
Hopefully a more portable way of testing this stuff.
https://reviews.llvm.org/D45839
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h
lib/StaticAnalyzer/Core/CallEvent.cpp
lib/StaticAnalyzer/Core/ExprEn
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs, baloghadamsoftware.
Since recently, WebKit uses a peculiar build system that compiles multiple
translation units at once by automatically joi
20 matches
Mail list logo
