[PATCH] D45815: [libclang] Allow skipping function bodies in preamble only

This revision was automatically updated to reflect the committed changes. Closed by commit rC332578: [libclang] Allow skipping function bodies in preamble only (authored by yvvan, committed by ). Changed prior to commit: https://reviews.llvm.org/D45815?vs=145648&id=147253#toc Repository: rC

[PATCH] D45815: [libclang] Allow skipping function bodies in preamble only

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D45815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D45815: [libclang] Allow skipping function bodies in preamble only

nik added inline comments. Comment at: include/clang/Frontend/ASTUnit.h:370 + IntrusiveRefCntPtr VFS, + SkipFunctionBodiesScope SkipFunctionBodiesScp = + SkipFunctionBodiesScope::None, ilya-biryukov wrote: > NIT: Maybe keep the name `SkipFuncti

[PATCH] D45815: [libclang] Allow skipping function bodies in preamble only

nik updated this revision to Diff 145648. nik marked 3 inline comments as done. nik edited the summary of this revision. nik added a comment. Addressed comments. Repository: rC Clang https://reviews.llvm.org/D45815 Files: include/clang-c/Index.h include/clang/Frontend/ASTUnit.h lib/Fro

[PATCH] D45815: [libclang] Allow skipping function bodies in preamble only

ilya-biryukov added a comment. Sorry for the delay Repository: rC Clang https://reviews.llvm.org/D45815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45815: [libclang] Allow skipping function bodies in preamble only

ilya-biryukov added inline comments. Comment at: include/clang/Frontend/ASTUnit.h:104 + enum class SkipFunctionBodiesScope { None, MainFileAndPreamble, Preamble }; + Maybe move this out of `ASTUnit`? Would allow removing the first qualifier in usages outside

[PATCH] D45815: [libclang] Allow skipping function bodies in preamble only

nik added a comment. Do I miss something? I've uploaded a new diff/version and state is still "(X) Requested Changes to Prior Diff". Waiting for review. Repository: rC Clang https://reviews.llvm.org/D45815 ___ cfe-commits mailing list cfe-commi

[PATCH] D45815: [libclang] Allow skipping function bodies in preamble only

nik added a comment. Trying to format the diff in the previous comment: --- a/lib/Parse/ParseCXXInlineMethods.cpp +++ b/lib/Parse/ParseCXXInlineMethods.cpp @@ -102,9 +102,14 @@ NamedDecl *Parser::ParseCXXInlineMethodDef(AccessSpecifier AS, } if (SkipFunctionBodies != SkipFunc

[PATCH] D45815: [libclang] Allow skipping function bodies in preamble only

nik added a comment. OK, to skip all function bodies in the preamble except for template functions and functions within a template class, I've amended the previous diff with: - a/lib/Parse/ParseCXXInlineMethods.cpp +++ b/lib/Parse/ParseCXXInlineMethods.cpp @@ -102,9 +102,14 @@ NamedDecl *Parse

[PATCH] D45815: [libclang] Allow skipping function bodies in preamble only

nik added inline comments. Comment at: lib/Parse/ParseCXXInlineMethods.cpp:104 - if (SkipFunctionBodies && (!FnD || Actions.canSkipFunctionBody(FnD)) && - trySkippingFunctionBody()) { + if (SkipFunctionBodies != SkipFunctionBodiesKind::None && + (!FnD || Actions.can