[PATCH] D45474: [XRay][clang+compiler-rt] Support build-time mode selection

2018-04-10 Thread Dean Michael Berris via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL329772: [XRay][clang+compiler-rt] Support build-time mode selection (authored by dberris, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D45474?v

[PATCH] D45474: [XRay][clang+compiler-rt] Support build-time mode selection

2018-04-10 Thread Dean Michael Berris via Phabricator via cfe-commits
dberris updated this revision to Diff 141940. dberris marked an inline comment as done. dberris added a comment. Revert unnecessary one-liner change. https://reviews.llvm.org/D45474 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/XRayArgs.h clang/lib/Driver/ToolCha

[PATCH] D45474: [XRay][clang+compiler-rt] Support build-time mode selection

2018-04-10 Thread Eric Christopher via Phabricator via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Sure. Comment at: clang/lib/Driver/XRayArgs.cpp:168 - for (const auto&AttrFile : AttrListFiles) { + for (const auto &AttrFile : AttrListFiles) { SmallString<64>

[PATCH] D45474: [XRay][clang+compiler-rt] Support build-time mode selection

2018-04-09 Thread Dean Michael Berris via Phabricator via cfe-commits
dberris created this revision. dberris added reviewers: echristo, eizan, chandlerc. Herald added subscribers: mgrang, mgorny. This patch implements the `-fxray-modes=` flag which allows users building with XRay instrumentation to decide which modes to pre-package into the binary being linked. The