[PATCH] D45468: [clang-tidy] Adding Fuchsia checker for human-readable logging

2018-04-10 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/zircon-human-readable-status.rst:6 + +Suggests fix for printf-family functions with a zx_status_t argument to convert +status argument to a human-readable string (zx_status_t is a Zircon kernel -

[PATCH] D45468: [clang-tidy] Adding Fuchsia checker for human-readable logging

2018-04-10 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added inline comments. Comment at: clang-tidy/zircon/HumanReadableStatusCheck.cpp:68 +SourceRange FmtStringRange; +for (const auto *Arg : D->arguments()) { + if (const auto *ICE = dyn_cast(Arg)) { Did you consider using `forEachArgumentWith

[PATCH] D45468: [clang-tidy] Adding Fuchsia checker for human-readable logging

2018-04-09 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, ilya-biryukov. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a checker to the Fuchsia module to flag instances of attempting to log the system's numerical