This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE329574: [clangd-vscode] Update VScode dependencies
(authored by malaperle, committed by ).
Changed prior to commit:
h
malaperle added a comment.
In https://reviews.llvm.org/D45285#1061374, @hokein wrote:
> In https://reviews.llvm.org/D45285#1061243, @ilya-biryukov wrote:
>
> > In https://reviews.llvm.org/D45285#1058567, @malaperle wrote:
> >
> > > Do we need to bump the version of the extension and do a new rele
hokein added a comment.
In https://reviews.llvm.org/D45285#1061243, @ilya-biryukov wrote:
> In https://reviews.llvm.org/D45285#1058567, @malaperle wrote:
>
> > Do we need to bump the version of the extension and do a new release or
> > anything like that? Or leave this for later?
>
>
> We should
ilya-biryukov added a subscriber: hokein.
ilya-biryukov added a comment.
In https://reviews.llvm.org/D45285#1058567, @malaperle wrote:
> Do we need to bump the version of the extension and do a new release or
> anything like that? Or leave this for later?
We should bump the version and republi
MaskRay added a comment.
Do we really want to keep editor plugins in the repository?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
malaperle added a comment.
Do we need to bump the version of the extension and do a new release or
anything like that? Or leave this for later?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45285
___
cfe-commits mailing list
cfe-c
ilya-biryukov accepted this revision.
ilya-biryukov added a reviewer: ilya-biryukov.
ilya-biryukov added a comment.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
malaperle created this revision.
Herald added subscribers: cfe-commits, MaskRay, ioeric, jkorous-apple,
ilya-biryukov, klimek.
malaperle retitled this revision from "[clangd-vscode] Vscode dependencies" to
"[clangd-vscode] Update VScode dependencies".
This allows the extension to work with LSP 3