[PATCH] D44778: [clang-format] Wildcard expansion on Windows.

This revision was automatically updated to reflect the committed changes. Closed by commit rC328495: [clang-format] Wildcard expansion on Windows. (authored by alexfh, committed by ). Changed prior to commit: https://reviews.llvm.org/D44778?vs=139593&id=139784#toc Repository: rC Clang https

[PATCH] D44778: [clang-format] Wildcard expansion on Windows.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: tools/clang-format/ClangFormat.cpp:348 + if (EC) { +llvm::errs() << "error: couldn'g get arguments: " << EC.message() << '\n'; + } s/couldn'

[PATCH] D44778: [clang-format] Wildcard expansion on Windows.

alexfh added a comment. I've not tested this on Windows, but I hope llvm::sys::Process::GetArgumentVector should have been tested by someone already. Repository: rC Clang https://reviews.llvm.org/D44778 ___ cfe-commits mailing list cfe-commits@

[PATCH] D44778: [clang-format] Wildcard expansion on Windows.

alexfh updated this revision to Diff 139593. alexfh added a comment. - Use llvm::sys::Process::GetArgumentVector. Repository: rC Clang https://reviews.llvm.org/D44778 Files: tools/clang-format/ClangFormat.cpp Index: tools/clang-format/ClangFormat.cpp =

[PATCH] D44778: [clang-format] Wildcard expansion on Windows.

alexfh added a comment. In https://reviews.llvm.org/D44778#1046301, @alexfh wrote: > In https://reviews.llvm.org/D44778#1046251, @rnk wrote: > > > Use `llvm::sys::Process::GetArgumentVector`, which already does wildcard > > expansion from what I can see. It works with Unicode command lines and

[PATCH] D44778: [clang-format] Wildcard expansion on Windows.

alexfh added a comment. In https://reviews.llvm.org/D44778#1046251, @rnk wrote: > Use `llvm::sys::Process::GetArgumentVector`, which already does wildcard > expansion from what I can see. It works with Unicode command lines and isn't > affected by locale. I vaguely remember that windows conso

[PATCH] D44778: [clang-format] Wildcard expansion on Windows.

rnk requested changes to this revision. rnk added a comment. This revision now requires changes to proceed. Use `llvm::sys::Process::GetArgumentVector`, which already does wildcard expansion from what I can see. It works with Unicode command lines and isn't affected by locale. Repository: rC

[PATCH] D44778: [clang-format] Wildcard expansion on Windows.

smeenai added a comment. PURE_WINDOWS is all Windows except Cygwin. It's an LLVM thing, not a CMake thing. I don't know if setargv.obj is available on MinGW, and even if it is it's probably not gonna have the .obj extension, so this should probably be limited to MSVC. Repository: rC Clang

[PATCH] D44778: [clang-format] Wildcard expansion on Windows.

zturner added subscribers: alexfh, zturner. zturner added a comment. Never seen this PURE_WINDOWS CMake variable. How is it different than MSVC? Repository: rC Clang https://reviews.llvm.org/D44778 ___ cfe-commits mailing list cfe-commits@lists.l

Re: [PATCH] D44778: [clang-format] Wildcard expansion on Windows.

Never seen this PURE_WINDOWS CMake variable. How is it different than MSVC? On Thu, Mar 22, 2018 at 5:30 AM Alexander Kornienko via Phabricator < revi...@reviews.llvm.org> wrote: > alexfh created this revision. > alexfh added reviewers: klimek, djasper. > Herald added a subscriber: mgorny. > > Add

[PATCH] D44778: [clang-format] Wildcard expansion on Windows.

alexfh created this revision. alexfh added reviewers: klimek, djasper. Herald added a subscriber: mgorny. Add support for wildcard expansion in command line arguments on Windows. See https://docs.microsoft.com/en-us/cpp/c-language/expanding-wildcard-arguments Fixes https://bugs.llvm.org/show_bug.