[PATCH] D44671: [libcxx] Enable static libcxxabi linking on Darwin

2019-03-29 Thread Petr Hosek via Phabricator via cfe-commits
phosek abandoned this revision. phosek added a comment. Herald added a subscriber: libcxx-commits. This was already implemented in D59513 . Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44671/new/ https://reviews.llvm.org/D4467

[PATCH] D44671: [libcxx] Enable static libcxxabi linking on Darwin

2018-08-08 Thread JF Bastien via Phabricator via cfe-commits
jfb added a comment. Were the concerns expressed in https://reviews.llvm.org/D8017 addressed? Repository: rCXX libc++ https://reviews.llvm.org/D44671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D44671: [libcxx] Enable static libcxxabi linking on Darwin

2018-03-20 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added a reviewer: dexonsmith. compnerd added a comment. I want to get Duncan's input on this. I don't think that this is a supported configuration for macOS. Repository: rCXX libc++ https://reviews.llvm.org/D44671 ___ cfe-commits maili

[PATCH] D44671: [libcxx] Enable static libcxxabi linking on Darwin

2018-03-20 Thread Petr Hosek via Phabricator via cfe-commits
phosek updated this revision to Diff 139163. phosek marked an inline comment as done. Repository: rCXX libc++ https://reviews.llvm.org/D44671 Files: libcxx/CMakeLists.txt Index: libcxx/CMakeLists.txt === --- libcxx/CMakeLists.

[PATCH] D44671: [libcxx] Enable static libcxxabi linking on Darwin

2018-03-19 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. I would imagine there was a reason this configuration was unsupported on macOS – perhaps something to do with libc++/libc++abi being the default system libraries on that platform? Comment at: libcxx/CMakeLists.txt:330 # Check that this option is no

[PATCH] D44671: [libcxx] Enable static libcxxabi linking on Darwin

2018-03-19 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. phosek added reviewers: EricWF, mclow.lists, compnerd, beanz. Herald added subscribers: cfe-commits, christof, mgorny. This seems to be working without any problems. Repository: rCXX libc++ https://reviews.llvm.org/D44671 Files: libcxx/CMakeLists.txt Index: