[PATCH] D43990: set dso_local on tls init functions

2018-03-07 Thread Rafael Avila de Espindola via Phabricator via cfe-commits
espindola closed this revision. espindola added a comment. r326961 https://reviews.llvm.org/D43990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43990: set dso_local on tls init functions

2018-03-07 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I think Richard has been really busy preparing for some C++ committee function. I think we should go forward with this. https://reviews.llvm.org/D43990 __

[PATCH] D43990: set dso_local on tls init functions

2018-03-07 Thread Rafael Avila de Espindola via Phabricator via cfe-commits
espindola added a comment. Richard, you added the setVisibility line, are you OK with the change? https://reviews.llvm.org/D43990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43990: set dso_local on tls init functions

2018-03-01 Thread Rafael Avila de Espindola via Phabricator via cfe-commits
espindola created this revision. espindola added a reviewer: echristo. We copy the visibility, so copying the dso_local flag seems the natural thing to do. https://reviews.llvm.org/D43990 Files: lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/runtime-dllstorage.cpp Index: test/CodeGenCXX/r